Delete laboratory.workbooks reference on workbook container delete#50
Merged
labkey-jeckels merged 1 commit intodevelopfrom Sep 16, 2020
Merged
Delete laboratory.workbooks reference on workbook container delete#50labkey-jeckels merged 1 commit intodevelopfrom
labkey-jeckels merged 1 commit intodevelopfrom
Conversation
labkey-ankurj
approved these changes
Sep 16, 2020
Collaborator
|
@labkey-jeckels I believe the behavior of leaving the rows in laboratory.workbooks used to be by design, since that table used to be the table of record for workbook ID, and if we deleted a workbook we wanted to skip over that number. however, a long time ago LabKey started numbering workbooks incrementally by container, and we now defer to LK's numbering. I think your change is fine. I just have one question: did DatabaseDiagnosticsTest change or become more robust recently? I think the laboratory.workbooks purge (or lack of purge) behavior was fairly old. |
Author
|
OK, thanks for confirming. The test hasn't changed, but it just started running in a suite that happened to exercise the lab workbook tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
DatabaseDiagnosticsTest is failing due to orphaned laboratory.workbooks rows that are missing their core.container row. A hard FK might be useful here, but it's possible that it would need to do a cascading delete of existing orphaned rows so keeping it simple for now.
Changes